Skip to content

feat(grids): add custom cell merging samples #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 29, 2025
Merged

feat(grids): add custom cell merging samples #1065

merged 12 commits into from
Oct 29, 2025

Conversation

@IMinchev64
Copy link
Contributor

@IMinchev64 IMinchev64 commented Oct 27, 2025

Related to this PR

This PR contains the following cell merging samples:

  • basic overview samples for the grid, hierarchical grid, and tree grid
  • custom cell merge strategy samples for grid, hierarchical grid, and tree grid

@IMinchev64 IMinchev64 mentioned this pull request Oct 27, 2025
Merged
@IMinchev64 IMinchev64 requested a review from mddragnev October 28, 2025 08:53
mddragnev
mddragnev requested changes Oct 28, 2025
View reviewed changes
@MarielaTihova MarielaTihova added status: in-test PR ready for testing status: verified The PR is tested and ready for a merge and removed status: in-test PR ready for testing status: verified The PR is tested and ready for a merge labels Oct 28, 2025
@MarielaTihova
Copy link
Contributor

MarielaTihova commented Oct 28, 2025

Some small comments on this PR:

  1. The label of the dropdowns appears alongside the other clickable options. It is a bit confusing for the user. Is there a way to make it look more appealing?
image
  1. On the hierarchical grid -> the custom merge strategy -> it seems like there is too little data. Currently the only thing that is displayed is data that doesn't meet the criteria from the custom merge strategy. It would be nice to show examples of data that meets the criteria in the same sample as well, so that the user can compare.

mddragnev
mddragnev requested changes Oct 29, 2025
View reviewed changes
mddragnev
mddragnev previously approved these changes Oct 29, 2025
View reviewed changes
@MarielaTihova MarielaTihova added the status: verified The PR is tested and ready for a merge label Oct 29, 2025
@dkamburov dkamburov merged commit f5a2a17 into vnext Oct 29, 2025
5 checks passed
@dkamburov dkamburov deleted the iminchev/cell-merge-custom branch October 29, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mddragnev mddragnev mddragnev approved these changes

Assignees

@dkamburov dkamburov

@MarielaTihova MarielaTihova

Labels

status: verified The PR is tested and ready for a merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IMinchev64 @MarielaTihova @mddragnev @dkamburov